Connection inspector: one status dot, and a title - #45
Merged
Conversation
The connection inspector showed "status: live" and then a separate `● live` line whose dot was never coloured. Drop the standalone line; the status fact now carries an inline `.conn-dot` — green when live, red when refused / timed out (`facts()` takes a Node value for this). Add a `connection` section heading to match `faults`, with the panel's first section losing its top divider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes to the connection inspector (shown when you select a wire):
status: livein the facts and a separate● liveline below — whose dot was plain grey, never green. The standaloneline is gone; the
statusfact now has an inline.conn-dotthat's greenwhen live and red when
refused/timed out(faults()— sorry,facts()— now accepts aNodevalue)..conn-dotgetsvertical-align: middleso it sits right next to the word.connectionsection title above the facts, tomatch
faults. The panel's first.insp-sectiondrops its top border sothere's no divider hanging above nothing.
yarn test(20) +yarn buildpass.